Re: CVS commit: src/sbin/resize_ffs

[christos%zoulas.com@localhost (Christos Zoulas)]

On Aug 28,  7:14pm, wiz%NetBSD.org@localhost (Thomas Klausner) wrote:
-- Subject: Re: CVS commit: src/sbin/resize_ffs

| On Sat, Aug 27, 2011 at 12:34:57PM -0400, Christos Zoulas wrote:
| > Module Name:        src
| > Committed By:       christos
| > Date:               Sat Aug 27 16:34:57 UTC 2011
| > 
| > Modified Files:
| >     src/sbin/resize_ffs: resize_ffs.8 resize_ffs.c
| > 
| > Log Message:
| > PR/45301: Julian Fagir: make clear that the unit is sectors and fix a typo.
| > While there, use errx, and sizeof(*var) instead of sizeof(type)
| 
| This leaves a sentence in the upper paragraph that doesn't make sense
| in the place, and also makes me curious if blocksizes != 512 are
| supported:

Where, the '.Nm\ncan both grow and shrink filesystems.'?

| It will not work correctly for file systems with other sector sizes.)
| 
| Is it correct?

I think so. The uses of DEV_BSIZE seem suspicious to me. Better safe than
sorry.

christos