Re: CVS commit: src/etc/mtree

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Tue, Sep 06, 2011 at 08:43:10 +0100, Iain Hibbert wrote:

> On Mon, 5 Sep 2011, Valeriy E. Ushakov wrote:
> 
> > On Mon, Sep 05, 2011 at 15:13:49 +0100, Iain Hibbert wrote:
> >
> > > On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:
> > >
> > > > On Mon, Sep 05, 2011 at 09:57:02AM +0000, Alan Barrett wrote:
> > > > > Module Name:  src
> > > > > Committed By: apb
> > > > > Date:         Mon Sep  5 09:57:02 UTC 2011
> > > > >
> > > > > Modified Files:
> > > > >       src/etc/mtree: Makefile
> > > > >
> > > > > Log Message:
> > > > > Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
> > > > > This fixes a problem in which NetBSD.dist.tmp had been created in
> > > > > the SRCDIR by an earlier build (performed without an OBJDIR), and
> > > > > the existence of the file in the SRCDIR confused a subsequent build
> > > > > (performed with an OBJDIR).
> > > >
> > > > Do we really want to add special cases like this? There are all kinds of
> > > > mysterious errors triggered by unclean SRCDIR, I don't think it is worth
> > > > adding this specific hack.
> > >
> > > IMO these cases are worth handling just because if an OBJDIR is specified,
> > > it should be used. The alternative being that the OBJDIR is used
> > > "sometimes"?  Thats just wrong..
> >
> > So whay do you treat NetBSD.dist.tmp and NetBSD.dist differently then?
> 
> Well, I don't know but ${.OBJDIR}/NetBSD.dist is already referenced in
> that file?
> 
> > If you go down that path, where do you stop?
> 
> You can sleep when you have a system that works as expected, not one that
> fails with mysterious errors because even though you told it to use an
> OBJDIR for work files, it was confused by some it found elsewhere. As
> noted, most of this is handled invisibly by the make framework, but some
> of it needs to be manually handled. I guess people fix things as they
> notice them..

Are you saying you are going to add a special case for each foo.o file
each time an accidental non-objdir build left foo.o in src? (and no,
that's not a rhetoric question).

-uwe