Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Sat, Sep 17, 2011 at 08:19:47PM +0200, Grégoire Sutre wrote:
> On 09/01/2011 05:10 PM, Christos Zoulas wrote:
> >Module Name: src
> >Committed By:        christos
> >Date:                Thu Sep  1 15:10:32 UTC 2011
> >
> >Modified Files:
> >     src/sys/arch/i386/eisa: eisa_machdep.c
> >     src/sys/arch/i386/mca: mca_machdep.c
> >     src/sys/arch/x86/include: bus_private.h
> >     src/sys/arch/x86/isa: isa_machdep.c
> >     src/sys/arch/x86/pci: pci_machdep.c
> >     src/sys/arch/x86/x86: bus_dma.c
> >     src/sys/arch/xen/xen: isa_machdep.c xpci_xenbus.c
> >     src/sys/sys: bus.h
> >
> >Log Message:
> >Add bus_dma overrides. From dyoung
> 
> Should NULL be allowed as first argument of bus_dma_tag_create?

It should not be.

> I would prefer for NULL to be allowed to make my life easier in
> the drmgem port from OpenBSD.  But maybe requiring non-NULL would
> make more sense if this shall be used from MI device drivers only?

I was working on this a week or two ago, I will send you a patch.

I found that you can simplify the drmgem code a lot if you use
bus_dma_tag_create() to refine an existing tag instead of trying to
create one from scratch.  I think that you can probably make the code
MI, too.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 344-0444 x24