re: CVS commit: src/lib/libc

[christos%zoulas.com@localhost (Christos Zoulas)]

On Oct 16,  4:06pm, mrg%eterna.com.au@localhost (matthew green) wrote:
-- Subject: re: CVS commit: src/lib/libc

| 
| >    Module Name:    src     
| >    Committed By:   christos                    
| >    Date:           Sat Oct 15 23:00:02 UTC 2011
| > 
| >    Modified Files:                           
| >            ...
| >            src/lib/libc/gen: fstab.c fts.c getcap.c getgrent.c getttyent.c
| >                getusershell.c initdir.c opendir.c syslog.c utmp.c utmpx.c
| >            ...
| > 
| >    close on exec fixes:            
| >    - open + fcntl -> open O_CLOEXEC
| >    - configuration database file descriptors that can stay open are now 
opened
| >      fopen(db, "re")
| > 
| > At least fts.c is used in libnbcompat, so this broke the tools build
| > on NetBSD 5 and probably lots of other systems.
| 
| this should be fixed now.

Thanks, but then shouldn't we also add:

#if O_CLOEXEC == 0
        (void)fcntl(sp->fts_rfd, F_SETFD, FD_CLOEXEC);
#endif

after the open?

christos