Re: CVS commit: src/external/bsd/atf/dist

[christos%astron.com@localhost (Christos Zoulas)]

In article <4EC3F8F7.8020104%NetBSD.org@localhost>,
Julio Merino  <jmmv%NetBSD.org@localhost> wrote:
>On 11/16/11 12:46 PM, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:        christos
>> Date:                Wed Nov 16 17:46:16 UTC 2011
>>
>> Modified Files:
>>      src/external/bsd/atf/dist/atf-c++/detail: text.cpp text.hpp
>>      src/external/bsd/atf/dist/atf-run: requirements.cpp test-program.cpp
>>
>> Log Message:
>> PR/45619: jmmv: Allow atf tests to request a minimum amount of memory
>
>Could you run intrusive changes to atf for review please?
>
>The current changes are incomplete and inappropriate, so they are going 
>to make integration upstream a pain.

Well, there is really no portable way to find the total available memory of
the system that I know of and I did not want to add ifdefs or machinery
to get this working on other OS's. If you know otherwise, feel free to fix it.

The changes are really small and they are additions only. I fail to see how
it is going to be difficult to integrate. The only difficulty here is to
make them portable across OS's, and that can be done with a getrealmemory()
stub function per OS, and include the sources for humanize_number for the
ones that don't have it.

christos