Re: CVS commit: src/lib/libc/net

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

> On Sat, Dec 24, 2011 at 10:17:37PM +0900, Izumi Tsutsui wrote:
> > > > Log Message:
> > > > Specify "-fno-tree-ter" to getaddrinfo.c and gethnamaddr.c on arm and 
> > > > gcc45
> > > > for workaround of a possible optimazation bug.
> > > 
> > > Please make sure this only is applied if the active CC is GCC.
> > 
> > Isn't this enough?
> > 
> > ---
> > .if defined(HAVE_GCC) && ${HAVE_GCC} == "45" && ${MACHINE_CPU} == "arm"   
> > COPTS.getaddrinfo.c+=       -fno-tree-ter
> > COPTS.gethnamaddr.c+=       -fno-tree-ter
> > .endif
> 
> No, this only checks that HAVE_GCC is supported. HAVE_GCC, HAVE_LLVM and
> HAVE_PCC are non-exclusive with a fallback order.

So what's the proper test?

I don't see any proper examples:
bin/csh/Makefile
games/phantasia/Makefile
lib/libedit/Makefile
sbin/fsdb/Makefile
etc.

Could you please fix them?

---
Izumi Tsutsui