re: CVS commit: src/lib/libc/net

[matthew green <mrg%eterna.com.au@localhost>]

> On Mon, Dec 26, 2011 at 05:49:41PM +1100, matthew green wrote:
> > 
> > > For completeness, it should be:
> > > 
> > > .if ${HAVE_GCC:U} == "45" && ${MACHINE_CPU} == "arm"
> > > COPTS.getaddrinfo.c+=     ${${ACTIVE_CC} == "gcc" :? -fno-tree-ter :}
> > > COPTS.gethnameaddr.c+=    ${${ACTIVE_CC} == "gcc" :? -fno-tree-ter :}
> > > .endif
> > 
> > why not just have:
> > 
> >    .if ${HAVE_GCC:U} == "45" && ${MACHINE_CPU} == "arm" && ${ACTIVE_CC} == 
> > "gcc"
> > 
> > and avoid the unusual make pattern and evaluating it twice?
> 
> That adds a lot of restrictions on when UNSUPPORT_COMPILER.XXX can be
> set. I don't think it's a good idea to do that.

i don't understand this.  can you explain it further?

> I am consider to provide an alternative version of CWARNFLAGS.${IMPSRC}
> though, which includes the active compiler.


.mrg.