Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/look



In article <4F473B48.1040608%NetBSD.org@localhost>,
Marc Balmer  <mbalmer%NetBSD.org@localhost> wrote:
>Am 23.02.12 23:57, schrieb Joerg Sonnenberger:
>> Module Name: src
>> Committed By:        joerg
>> Date:                Thu Feb 23 22:57:53 UTC 2012
>> 
>> Modified Files:
>>      src/usr.bin/look: look.c
>> 
>> Log Message:
>> Don't use while-loop with empty body.
>
>I see you did several such changes.  What is the reason behind this,
>i.e. what is wrong with such loops?

They don't show the programmer's intend. I am still pissed off about me
spending hours debugging something that did:

        if (condition);
                a += 3;

But of course it was hidden in thousands of lines of code, so it was
hard to find.

christos



Home | Main Index | Thread Index | Old Index