Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/fs/msdosfs



On Jul 5,  1:34am, tsutsui%ceres.dti.ne.jp@localhost (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src/sys/fs/msdosfs

| Hmm, as you say md(4) would have failed in msdosfs_mountfs()
| even before getdisksize() was introduced and the only problem
| was in disklabel support addition to md(4).

That is correct. Centralizing the function makes it easier to fix.
 
| Anyway KASSERT() (or sanity check) should also be centralized
| to getdisksize()?

Well, I am not sure if KASSERT() is the best solution here. But
what else can we do? I agree that there should be at least a
warning.

christos


Home | Main Index | Thread Index | Old Index