Re: CVS commit: src

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Joerg Sonnenberger <joerg%britannica.bec.de@localhost> wrote:
> > Log Message:
> > Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby.
> > The code is taken from the upstream and is in the public domain.
> > 
> > OK christos@
> 
> There are a number of issues with this. First of all, it pollutes the
> global namespace and can't be used safely from libc the way it is done.

How do you suggest to do it?

> Second, I don't really like adding a special purpose name of a hash
> function which is explicitly not designed to be endian neutral. We
> should provide a fast hash function and be able to change it without
> breaking assumptions, which this is not doing.

Well, the added function is endian-neutral and is generic implementation.
Idea is to provide optimised functions per architecture.  They would
merely override the generic one, but produce the same result regardless
of endianess.  Do you want to do it differently?

-- 
Mindaugas