Re: CVS commit: src/sys

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Jul 31, 2012 at 11:58:51AM -0500, Jonathan A. Kollasch wrote:
> On Tue, Jul 31, 2012 at 03:50:39PM +0000, Manuel Bouyer wrote:
> > Apply back changes that were reverted on Jul 24 and Jul 26 (general ata/wdc
> > cleanup and SATA PMP support), now that I'm back to fix the fallouts.
> 
> What about the fallout (that on inspection of the code I'm fairly sure
> exists) that won't be immediately detected?  The drive_type change is
> far too significant to be applied with other unrelated changes as well.

Something has to be changed in this area anyway, because we have to add
a new type for port multipliers. The existing bitmask scheme doesn't
scale.

Yes, the change is large but there's not so many places where it matters.

If you know of other problems, please report.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--