Re: CVS commit: src/sys

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

On Thu, 2 Aug 2012 21:31:56 +0100
Mindaugas Rasiukevicius <rmind%netbsd.org@localhost> wrote:
> Also, thinking to use FreeBSD code for validation (plus checking for
> memwords we have).  It seems to be simpler and faster:
>
> http://www.netbsd.org/~rmind/bpf_validate.diff

I don't see where this is so much better than ours. OK,
it validates whether all opcodes are valid ones by a
bitmask, but the filter behaves reasonably if it encounters
an opcode it doesn't understand - it rejects the packet.
It is also strange why the bitmask is an array of shorts.

Our code is pretty mature, I wouldn't fix things which
are not broken.

best regards
Matthias


------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------

Kennen Sie schon unsere app? http://www.fz-juelich.de/app