Re: CVS commit: src/sys/arch/xen/x86

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Aug 21, 2012 at 01:17:46AM +0000, Mindaugas Rasiukevicius wrote:
> Module Name:  src
> Committed By: rmind
> Date:         Tue Aug 21 01:17:46 UTC 2012
> 
> Modified Files:
>       src/sys/arch/xen/x86: x86_xpmap.c
> 
> Log Message:
> Fix Xen build.  Make xcpumask uint32_t, fits 32 CPUs (can increase).

this is a regression. This used to work with 64 CPUs on 64bit guests.

Ho, and this is bogus too: you're now giving Xen a uint32_t * pointer,
while it's going to read it as a u_long. The upper 32bits will contain
garbage.

Why didn't you use u_long * for  kcpuset_* interface ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--