Re: CVS commit: src/sys/dev/usb

["Jonathan A. Kollasch" <jakllsch%kollasch.net@localhost>]

On Fri, Aug 24, 2012 at 12:20:03PM +0000, Matthias Drochner wrote:
> Module Name:  src
> Committed By: drochner
> Date:         Fri Aug 24 12:20:02 UTC 2012
> 
> Modified Files:
>       src/sys/dev/usb: umass.c umass_quirks.c umassvar.h
> 
> Log Message:
> Another contribution to PR kern/42225 which will hopefully
> bring the story to an end:
> 
> Always ignore the residue from the CSW, just use the real
> transfer length counted by the USB stack. This was first
> proposed by Markus Kilbinger but unfortunately ignored
> later. (Too many cooks...)
> According to Matthias Kretschmer, Darwin and Haiku do
> the same.
> 
> Remove the "UMASS_QUIRK_IGNORE_RESIDUE" quirk which was
> just for the one "SuperTop" device mentioned in the PR.
> This device was successfully tested by Matthias Kretschmer /
> Ignatios Souvatzis.
> 
> I've tested the patch with various other devices and
> didn't find regressions.

I still object.

        Jonathan Kollasch