Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



On Wed, Aug 29, 2012 at 04:50:10PM +0000, Jonathan A. Kollasch wrote:
> Module Name:  src
> Committed By: jakllsch
> Date:         Wed Aug 29 16:50:10 UTC 2012
> 
> Modified Files:
>       src/sys/dev/ic: mvsatareg.h
> 
> Log Message:
> mvsata(4) DMA data structures are already __packed, but as the hardware
> requires them to be 8-byte aligned, add __aligned(8) too, so that accesses
> on strict alignment platforms are more efficent.

Sounds like it would be better to remove the overall __packed and use
explicit __aligned(n) on the members that are not correctly aligned.

        David

-- 
David Laight: david%l8s.co.uk@localhost


Home | Main Index | Thread Index | Old Index