Re: CVS commit: src/sys/sys

[Alan Barrett <apb%cequrux.com@localhost>]

On Sat, 01 Dec 2012, Nick Hudson wrote:
> Log Message:
> Check for _NETBSD_SOURCE being defined wherever we check for
> _INCOMPLETE_XOPEN_C063 so that we expose the new POSIX extended API set
> recently added.



The idea behind _INCOMPLETE_XOPEN_C063 was to make the incomplete 
implementation hidden by default, requiring explicit action to 
make it visible.  If the implementation is now sufficiently 
complete that there is no longer a need for it to be hidden by 
default, then there is probably no need for the preprocessor 
symbol _INCOMPLETE_XOPEN_C063 to exist at all.  On the other hand, 
if the implementation si still incomplete, then exposing it when 
_NETBSD_SOURCE is defined seems wrong.  I don't see any third scenario
in which it makes sense to test defined(_NETBSD_SOURCE) ||
defined(_INCOMPLETE_

--apb (Alan Barrett)
From: Alan Barrett <apb%cequrux.com@localhost>
To: source-changes-d%NetBSD.org@localhost
Cc: 
Bcc: 
Subject: Re: CVS commit: src/sys/sys
Reply-To: 
In-Reply-To: <20121201082055.886F7175DF%cvs.netbsd.org@localhost>

On Sat, 01 Dec 2012, Nick Hudson wrote:
> Log Message:
> Check for _NETBSD_SOURCE being defined wherever we check for
> _INCOMPLETE_XOPEN_C063 so that we expose the new POSIX extended API set
> recently added.

This exposes the implementation by default.  If the implementation 
is ready for that, then there is probably no need for the 
preprocessor symbol _INCOMPLETE_XOPEN_C063 to exist at all.

--apb (Alan Barrett)