Re: CVS commit: src/sys/arch/amiga/conf

[Iain Hibbert <plunky%ogmig.net@localhost>]

On Fri, 11 Jan 2013, Havard Eidnes wrote:

> Module Name:  src
> Committed By: he
> Date:         Fri Jan 11 11:00:33 UTC 2013
>
> Modified Files:
>       src/sys/arch/amiga/conf: files.amiga
>
> Log Message:
> We appear to need files.usb included to get opt_usb.h generated,
> to make hid.c build.  The inclusion of hid.c in the build is probably
> triggered by some configs including bluetooth support, and hid.c
> is apparently both for bluetooth and usb.

yes, it is the same protocol.

(and ultimately, I would like to merge the two sets of drivers)

> I'm not sure what changed to make the build fail in the first place,
> though.

matt@ changed USB_DEBUG a while ago to be defined in opt_usb.h instead of
on the command line like all the other XXX_DEBUG flags provided by kernel
configuration. But, he did not change any of the files that rely on it to
actually include opt_usb.h, so christos@ is now trying to clean up..

The hid.c file compiles in some debug printing when UHIDEV_DEBUG is
defined. Usually, this is provided by the commandline, but it may also be
defined in dev/usb.h if USB_DEBUG is defined, so now that needs to include
opt_usb.h.

hid.c could likely do without UHIDEV_DEBUG

regards,
iain