Re: CVS commit: src/sys/kern

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Wed, Jan 30, 2013 at 09:36:56 +0000, Martin Husemann wrote:

> On Wed, Jan 30, 2013 at 08:07:14AM +0000, David Laight wrote:
> > On Tue, Jan 29, 2013 at 11:00:31PM +0000, Lars Heidieker wrote:
> > > Module Name:      src
> > > Committed By:     para
> > > Date:             Tue Jan 29 23:00:31 UTC 2013
> > > 
> > > Modified Files:
> > >   src/sys/kern: kern_sysctl.c
> > > 
> > > Log Message:
> > > fix the sysctl_setup_func typedef
> > 
> > -typedef void (*sysctl_setup_func)(struct sysctllog **);
> > +typedef void sysctl_setup_func(struct sysctllog **);
> > 
> > IIRC you are only supposed to be able to typedef pointers to functions.
> 
> You can use typdef for a function instead of a function pointer, but then
> you can only declare args/variables as sysctl_setup_func*.
> 
> This does not look like an improvement to me.

__link_set* macros add that extra "pointer to":

#define __link_set_decl(set, ptype)                                     \
        extern ptype * const __start_link_set_##set[] __dso_hidden;     \
        extern ptype * const __stop_link_set_##set[] __dso_hidden       \

-uwe