Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sbin/disklabel
On May 15, 9:48am, tsugutomo.enami%jp.sony.com@localhost
(tsugutomo.enami%jp.sony.com@localhost) wrote:
-- Subject: Re: CVS commit: src/sbin/disklabel
| Christos Zoulas <christos%astron.com@localhost> writes:
|
| > Are you worried about efficiency here? Yes, you can fix it differently
| > by checking if LABEL_OFFSET fits.
|
| I don't worry about efficiency.
|
| I've just noticed build failure on i386, and wondering what was wrong.
|
| I thought it would be better if warned when LABEL_OFFSET exceeds
| bootarea_len, but strictly speaking it is different matter.
Yes, I got confused with the format string and gcc is not very picky
about incorrect types. I fixed it, but yes, we can fix it differently.
christos
Home |
Main Index |
Thread Index |
Old Index