Re: CVS commit: src/external/mit/xorg/lib/fontconfig/src

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Tue, Jun 25, 2013 at 04:24:27PM +0200, Joerg Sonnenberger wrote:
> On Tue, Jun 25, 2013 at 02:05:05PM +0000, Thomas Klausner wrote:
> > Module Name:        src
> > Committed By:       wiz
> > Date:               Tue Jun 25 14:05:04 UTC 2013
> > 
> > Modified Files:
> >     src/external/mit/xorg/lib/fontconfig/src: Makefile
> > 
> > Log Message:
> > Add -Wno-error=tautological-constant-out-of-range-compare for clang, to 
> > avoid
> > ../external/mit/fontconfig/dist/src/fcname.c:89:18: error: comparison of 
> > constant
> > 4294967295 with expression of type 'const FcType' (aka 'const enum 
> > _FcType') is
> > always false [-Werror,-Wtautological-constant-out-of-range-compare]
> >             if (t->type == (unsigned int) -1 || type == t->type)
> >                 ~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > 
> > and a few others of the same type.
> 
> It should still be reported upstream, this is bogus...

http://lists.freedesktop.org/archives/fontconfig/2013-June/004789.html

There are more, e.g. in Mesa.
external/mit/libX11/dist/src/Font.c:591:29: warning: comparison of constant 
768614336404564650 with expression of type 'CARD32' (aka 'unsigned int') is 
always true [-Wtautological-constant-out-of-range-compare]
                      && reply.nCharInfos < (LONG_MAX / sizeof(XCharStruct))
                         ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

 Thomas