Re: CVS commit: src/sys/rump

[Antti Kantee <pooka%NetBSD.org@localhost>]

On 4.7.2013 14:53, Valery Ushakov wrote:
> On Thu, Jul 04, 2013 at 10:14:04 +0000, Antti Kantee wrote:
>
> > Module Name:    src
> > Committed By:   pooka
> > Date:           Thu Jul  4 10:14:04 UTC 2013
> >
> > Modified Files:
> >         src/sys/rump: Makefile.rump
> >
> > Log Message:
> > Apparently warning flags are not kept in CWARNFLAGS.  Compensate.
>
> Would you care to elaborate?  Do you refer to the fact that bsd.sys.mk
> adds -Werror to CFLAGS instead of CWARNFLAGS?
>
> CFLAGS+=        ${${_NOWERROR} == "no" :?-Werror:} ${CWARNFLAGS}

That and this:

.if ${WARNS} > 1
CFLAGS+=        -Wreturn-type -Wswitch -Wshadow
.endif
.if ${WARNS} > 2
CFLAGS+=        -Wcast-qual -Wwrite-strings
CFLAGS+=        -Wextra -Wno-unused-parameter
# Readd -Wno-sign-compare to override -Wextra with clang
CFLAGS+=        -Wno-sign-compare
[...]