Re: CVS commit: src/sys/modules/lua

[Marc Balmer <mbalmer%NetBSD.org@localhost>]

Am 17.10.13 00:26, schrieb Alexander Nasonov:
> Two things attracted my eyes after a very quick look.
> 
>> +#define exit(EXIT_FAILURE)     return
> 
> I can't believe this code in the tree! I thought we agreed that it will
> be changed.
> 
> What's the point of compiling unmodified Lua sources if it forces you
> to write ugly hacks? It's perfectly fine to insert few #ifndef _KERNEL
> to the Lua source.

Agreed, I think.

> 
>> +++ src/sys/modules/lua/infinite.lua Wed Oct 16 19:44:57 2013
>> @@ -0,0 +1,2 @@
>> +while (1) do end
> 
> Why do you need this file at all and why the code starts like C and ends
> like Lua?
> 
>       while true do end
> 
> no?

It is Lua code.  It is an infinite loop.  It is there so that execution
limit count can be tested.