Re: CVS commit: src/sys

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Sun, May 25, 2014 at 04:31:51PM +0000, Antti Kantee wrote:
 > Modified Files:
 >      src/sys/kern: subr_devsw.c vfs_bio.c
 >      src/sys/rump/librump/rumpkern: rump.c
 > 
 > Log Message:
 > Call biodone() in the bdev_strategy() error via a pointer.  Decouples
 > subr_devsw from VFS -- not that I/O buffers are _VFS_ entities -- 

Yes they are... so are devsw entries, for that matter.

I have no idea how you expect buffer ops to be able to work without
biodone; but given that your usual response when I ask this sort of
question is to tell me I don't understand, I don't really expect a
helpful explanation.

In any event though, can we please fix this properly instead of
introducing a gross hack? If this is the only place biodone is
referenced at this level, then it's quite likely that as you say the
caller should be handling it.

-- 
David A. Holland
dholland%netbsd.org@localhost