re: CVS commit: src/sys/dev/pci/hdaudio

[matthew green <mrg%eterna.com.au@localhost>]

"Nathanial Sloss" writes:
> Module Name:	src
> Committed By:	nat
> Date:		Sun Sep 21 10:41:23 UTC 2014
> 
> Modified Files:
> 	src/sys/dev/pci/hdaudio: hdafg.c
> 
> Log Message:
> Enable sysbeep(4) to be heard on speakers on Toughbook mk1 and mk5
> computers.  Also on computers with SigmaTel STAC 9200(D), 9202(D)
> 9404(D), 9205(D) hdaudio controllers as well as Realtek ALC 231
> hdaudio controllers reporting as ALC 269.
> 
> Addresses PR 45778.
> Addresses PR 48495.
> 
> This commit was approved by christos@

would you mind replacing the magic numbers you've added with
some sort of defines or so?  these lines:

+                       nid = 0x01;

+                       response = hdaudio_command(sc->sc_codec, nid,
+                           HDAFG_GET_ANACTRL, 0x00);

+                       nid = 0xf;
+                       response = hdaudio_command(sc->sc_codec, nid,
+                           CORB_SET_AMPLIFIER_GAIN_MUTE, 0x7100);

thanks.


.mrg.