Re: CVS commit: src/sys

[Justin Cormack <justin%specialbusservice.com@localhost>]

On Sat, Nov 15, 2014 at 6:49 PM, Takeshi Nakayama <nakayama%netbsd.org@localhost> wrote:
> Module Name:    src
> Committed By:   nakayama
> Date:           Sat Nov 15 18:49:05 UTC 2014
>
> Modified Files:
>         src/sys/netsmb: iconv.c
>         src/sys/rump/dev/lib/libnetsmb: Makefile
> Added Files:
>         src/sys/rump/dev/lib/libnetsmb: netsmb_iconv.c netsmb_user.c
>             netsmb_user.h
>
> Log Message:
> Make rump_smbfs(8) uses host iconv(3) to convert filenames
> character set.

Er, you can't do that.

1. It breaks the rump builds on most platforms
http://build.myriabit.eu:8012/waterfall as the prototypes dont match
eg see http://build.myriabit.eu:8012/builders/ppc64-cross/builds/5585/steps/shell_3/logs/stdio
2. There is no requirement that rump runs on a platform that has iconv
anyway, it may be running on bare metal, or non Posix platform.

Not sure what the intention was though - I am sure we can find a way
around it...

Justin