Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys



"Christos Zoulas" writes:
> Module Name:	src
> Committed By:	christos
> Date:		Fri Jan  2 19:42:07 UTC 2015
> 
> Modified Files:
[ ... ]
> 
> Log Message:
> We have three sets of DTYPE_ constants in the kernel:
> 	altq		Drop 		Type
> 	disklabel	Disk 		Type
> 	file		Descriptor	Type
> (not to mention constants that contain the string DTYPE).
> Let's make them two, by changing the disklabel one to be DisK TYPE since the
> other disklabel constants seem to do that. Not many userland programs use
> these constants (and the ones that they do are mostly in ifdefs). They will
> be fixed shortly.

this seems strange to me.

we have a published userland interface and you chose that
one to change?  so userland apps must be fixed.  it seems
much saner to me to fix the other in-kernel users to not
conflict with the published interfaces.

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index