Re: CVS commit: [nick-nhusb] src/sys/dev/usb

[Nick Hudson <skrll%netbsd.org@localhost>]

On 03/06/15 11:36, Takahiro HAYASHI wrote:
> On 2015/03/05 21:39, Nick Hudson wrote:
> > Modified Files:
> >     src/sys/dev/usb [nick-nhusb]: usbdi.c
> >
> > Log Message:
> > Minor USBHIST_LOG changes
>
> >     /* Sync transfer, wait for completion. */
> >     if (err != USBD_IN_PROGRESS) {
> > -        USBHIST_LOG(usbdebug, "<- done xfer %p, not in progress", xfer,
> > +        USBHIST_LOG(usbdebug, "<- done xfer %p, err %d 
> > (complete/error)", xfer,
> >             0, 0, 0);
> >         return err;
> >     }
>
> Do you want to print 'err' instead of 0?
Fixed. Thanks.

> BTW, typeof err is usbd_status so ENOMEM is not suitable.

I fixed one place where this was a problem - did you spot others?

Thanks,
Nick