Re: CVS commit: src/sys/dev/bluetooth

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 30/04/2015 16:07, Christos Zoulas a écrit :
> On Apr 30,  8:57am, max%m00nbsd.net@localhost (Maxime Villard) wrote:
> -- Subject: Re: CVS commit: src/sys/dev/bluetooth
>
> How about helping investigate what's wrong with:
>
>          /* Check the size of cylinder groups */
>          fs_cgsize = ffs_fragroundup(fs, CGSIZE(fs));
>          if (fs->fs_cgsize != fs_cgsize)
>                  return 0;
>
>
> christos

Yes, ffs_oldfscompat_read() should theoretically be called before
ffs_superblock_validate(), otherwise, several fields being overwritten,
you either end up with unsanitized values or your disk gets kicked out.

It's true for almost all the changes I have made so far, and it is true
for this one too: fs_qfmask is overwritten for FS_44INODEFMT compat.

But given how broken it was (and is still a bit), how untested the
whole FFS code was, and given the glamorous XXX in ffs_oldfscompat_read,
I didn't touch this.