Re: CVS commit: src/sys/dev/pci

[christos%astron.com@localhost (Christos Zoulas)]

In article <557E89AE.8070004%execsw.org@localhost>,
Masanobu SAITOH  <msaitoh%execsw.org@localhost> wrote:
>
> I thought it's not required to wait API was fixed and committed.

I think is better to wait or ask before committing when there is
doubt.

> To support only MSI is easy, but MSI-X is not. This commit includes not
>only pci_intr_establish() stuff but also include other MSI-X stuff to setup
>MSI-X vector table and interrupt related functions. And, it'll take time
>to check regression or stability to make it enable by default, so it's
>important other people to test with it.

Even with the broken API, there is no need to triplicate the
interrupt allocation code, kcpuset distribution as I've shown before
in a different patch. Yes, it is more general if you copy the the
code because the tx/rx/link code *can potentially* be different,
but in this case it is not.

christos