Re: CVS commit: src/sys/dev/pci

[Antti Kantee <pooka%NetBSD.org@localhost>]

On 25/08/15 06:54, matthew green wrote:
> "Antti Kantee" writes:
> > Module Name:	src
> > Committed By:	pooka
> > Date:		Mon Aug 24 23:52:18 UTC 2015
> >
> > Modified Files:
> > 	src/sys/dev/pci: if_iwn.c
> >
> > Log Message:
> > Remove "#ifdef INET" code.  Por que?  Because opt_inet.h was not included
> > and "#ifdef INET" was just a fancy way of saying "#ifndef NetBSD".
>
> hmmmm, while the code wasn't used before, are you sure it isn't
> actually what we would rather be using?
>
> i ask because i count 57 calls to arp_ifinit() in our tree today
> (including this removed one), so i'm mostly convinced that it should
> be called, but the failure mode of not doing so is less severe than
> fails to work.

I assume that they're drivers which want to catch SIOCINITIFADDR instead 
of letting it pass through to ether_ioctl().  The call is 99% likely a 
leftover of porting the driver from OpenBSD.  At least when I ported iwm 
from NetBSD to OpenBSD, I added an #ifdef __OpenBSD__ block to call to 
arp_ifinit() from SIOCSIFADDR.  So, no, I don't think arp_ifinit() 
should be called from that driver.