Re: CVS commit: src/lib/libpanel

[Kamil Rytarowski <n54%gmx.com@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 02.11.2015 02:42, Christos Zoulas wrote:
> In article <20151102010615.A199F9A%cvs.netbsd.org@localhost>, Kamil
> Rytarowski <source-changes-d%NetBSD.org@localhost> wrote:
>> -=-=-=-=-=-
>> 
>> Module Name:	src Committed By:	kamil Date:		Mon Nov  2 01:06:15
>> UTC 2015
>> 
>> Modified Files: src/lib/libpanel: above.c bottom.c del.c hidden.c
>> new.c panel.h panel_impl.h replace.c show.c top.c window.c
>> 
>> Log Message: No functional changes
>> 
>> Make this code nicer for C++ compilers, don't assign char* to
>> void*. Add extra __prefix_false() CPU hint for failed malloc(3). 
>> Normalize whitespace.
> 
> The blank line at the beginning of functions that don't contain
> declarations is part of style... I am not enamored by it, but it is
> what it is.

I will revert this part.

> As far as casts go, the casts that cast from void * to other types
> (return of malloc) should go. This is not c++ (and if it was meant
> to be compiled for c++ it should be using modern c++ casts) because
> casting malloc only hides the fact that you forgot to include
> <stdlib.h>...
> 

I integrated libpanel(8) with lldb(1) for NetBSD-7.0, as I'm using
there our native curses(8). libpanel(8) is a missing part out there.

The user member isn't used with malloc(3)-like functions. Should it
stay for some reason void*?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWNsM1AAoJEEuzCOmwLnZsvsoP/1aFfvVNy8ho73UnpYDSk7o8
bNh2jbksBt9mXmlysW5mSCGtPdthbJbfeW2haLV0zHyxVQkyh9BeeowrQmE1Ohnn
ETZpGMkHlciou0nOM40qe9dCzH5wzNINeJn2Kaf1EmxiHRKz0Yb1nKubh67JX3n5
6+sE4DPkoV4+OTytoIfb43oSMgtXawgUS/AZVk1zaBOuAYdu9qzHlqLXgkP0gCX3
RRFc3izNNuKl0cNF3aPnYxiFdx9IlChocwF54EyRNygbjnnGvygp6jgh21BSLR0G
ShyML0d3ENWjX95xVl45u+8XvCov4RFaYIdcW65mIda3+T+9UWH1v426lCeuypRi
I0wOYWTcikMwNTOTtLYvJ8bPn3GrxjFPynitIzTydDJGXCnCM+9o4ItJCOoX+kac
yjjJrLOId1ioHL7cM+qIRB1vEU0Xgw/ifzQP6WOjBiZLcGLuS4R3KuWeJ0iuEVpk
a/SwIDtUOsna8dhpCXZe6g5b37FvbvssBLDPFvc/ez1IbgWfcDQgG42VNKp+afyv
YKxaNdi5NeroXPV4Z3gzFNY6O9mH/HdCpBTydBO4gbuvONTH33oLWlr/tCwzp6Xd
nOXCD5Fj0AVMLxVYByJ60cMg2U0wpp0SHzSm3l10slqZ2sqpEsJ8ZSArXUbelHsD
WWeHhv1mhoDSX9z6hywf
=Vie8
-----END PGP SIGNATURE-----