Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/gpt



On Dec 3,  6:54am, kre%munnari.OZ.AU@localhost (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/sbin/gpt

|     Date:        Wed, 2 Dec 2015 17:41:08 -0500
|     From:        christos%zoulas.com@localhost (Christos Zoulas)
|     Message-ID:  <20151202224108.9064B17FDAB%rebar.astron.com@localhost>
| 
|   | I observe data going to stdout because:
|   | static const char *outfile = "/dev/stdout";
| 
| Oh yes, OK, sorry - missed that.    It isn't a style I would use, so
| I wasn't expecting that.   I dislike assigning to a gobal var from a
| source that might come from anywhere ... in current invocation it is
| from the arg list, so isstable, but someone might add an interactive
| gpt mode, and then this method would break badly.

Yes, I am fixing those in the next pass (no static globals).

christos


Home | Main Index | Thread Index | Old Index