Re: CVS commit: src

[Paul Goyette <paul%vps1.whooppee.com@localhost>]

On Mon, 7 Dec 2015, Ryo ONODERA wrote:

> Hi,
>
> This breaks the kernel build as follows.
>
> /usr/src/sys/dev/clockctl.c:155:1: error: no previous prototype for 'clockctl_init' [-Werror=missing-prototypes]
> clockctl_init(void)
> ^
> cc1: all warnings being treated as errors
> *** [clockctl.o] Error code 1
>
>
> Lacking like this?

Yes - please go ahead and commit.



> Index: sys/sys/clockctl.h
> ===================================================================
> RCS file: /cvsroot/src/sys/sys/clockctl.h,v
> retrieving revision 1.16
> diff -u -r1.16 clockctl.h
> --- sys/sys/clockctl.h	6 Sep 2015 06:01:02 -0000	1.16
> +++ sys/sys/clockctl.h	7 Dec 2015 05:00:06 -0000
> @@ -71,6 +71,7 @@
> void    clockctlattach(int);
> int     clockctlopen(dev_t, int, int, struct lwp *);
> int     clockctlclose(dev_t, int, int, struct lwp *);
> +int     clockctl_init(void);
> int     clockctlioctl(dev_t, u_long, void *, int, struct lwp *);
> #endif
>
>
> From: "Paul Goyette" <pgoyette%netbsd.org@localhost>, Date: Mon, 7 Dec 2015 03:25:58 +0000
>
> > Module Name:	src
> > Committed By:	pgoyette
> > Date:		Mon Dec  7 03:25:58 UTC 2015
> >
> > Modified Files:
> > 	src/distrib/sets/lists/modules: mi
> > 	src/sys/compat/common: kern_time_50.c
> > 	src/sys/dev: clockctl.c
> > 	src/sys/modules: Makefile
> > Added Files:
> > 	src/sys/modules/clockctl: Makefile clockctl.ioconf
> >
> > Log Message:
> > Modularize the clockctl pseudo-device and link to the build.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.80 -r1.81 src/distrib/sets/lists/modules/mi
> > cvs rdiff -u -r1.29 -r1.30 src/sys/compat/common/kern_time_50.c
> > cvs rdiff -u -r1.32 -r1.33 src/sys/dev/clockctl.c
> > cvs rdiff -u -r1.162 -r1.163 src/sys/modules/Makefile
> > cvs rdiff -u -r0 -r1.1 src/sys/modules/clockctl/Makefile \
> >     src/sys/modules/clockctl/clockctl.ioconf
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
>
> --
> Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

+------------------+--------------------------+------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+------------------+--------------------------+------------------------+