On Wed, 6 Jan 2016, Paul Goyette wrote:
On Wed, 6 Jan 2016, Christos Zoulas wrote:In article <20160106015453.6F0F8FBB7%cvs.NetBSD.org@localhost>, Paul Goyette <source-changes-d%NetBSD.org@localhost> wrote:-=-=-=-=-=- Module Name: src Committed By: pgoyette Date: Wed Jan 6 01:54:53 UTC 2016 Modified Files: src/share/man/man4: filemon.4 Log Message: Add a BUGS section...Until this is fixed properly, you should prevent the ioctl from succeeding by returning EPERM or EINVAL, instead of succeeding and deadlocking later.Hmmm. I'm looking at the filemon_open() code. It seems to have a "fd" variable that gets set by fd_allocfile(). The value is later passed to fd_clone() (NOT fd_clone() - two different routines, apparently!).
^^^^^^^^^^
should say fdclone(9)
Too much confusion in routine names here!
The value inside filemon_open() is 4, but when the application program prints its returned value from open() it has fd #3.Unless I can reliably determine which fd the program is using for its access to /dev/filemon I don't have anything to which I can compare the requested activity_log fd.+------------------+--------------------------+------------------------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +------------------+--------------------------+------------------------+ !DSPAM:568c90e0240441760212287!
+------------------+--------------------------+------------------------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +------------------+--------------------------+------------------------+