Re: CVS commit: src/bin/sh

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Sat, 27 Feb 2016 13:34:12 -0500
    From:        "Christos Zoulas" <christos%netbsd.org@localhost>
    Message-ID:  <20160227183412.9B89CFBB7%cvs.NetBSD.org@localhost>

  | Modified Files:
  | 	src/bin/sh: Makefile eval.c main.c mknodenames.sh show.c
  | 
  | Log Message:
  | Improve debugging, from kre (I hooked it to the build).

Thanks for all of that.   But (unless I have missed something - I
have only looked at this so far via cvsweb) I think that if you
build as it is now, with DEBUG defined, you'll get an undefined symbol
on NodeNames.

Exactly one of the .c files needs to #include "nodenames.h" after
having done #define DEFINE_NODENAMES

At the minute, it looks as if you have eval.c #including nodenames.h
without that #define, and nothing else #including it at all.
It would be useful in show.h as well.

It doesn't make any practical difference which file includes it
with DEFINE_NODENAMES, in some ways it would be kind of nice for
that to be init.c - but that would mean modifying the script that
generates that file, and that looks messy.   main.c is another
reasonable choice.   Or it could just be show.c - especially as
that file is essentially all just debugging.

kre

ps: apologies in advance if I missed something from looking at the
diffs on cvsweb.   I will fetch the files a bit later.