Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
re: CVS commit: src/sys/arch/amd64/amd64
Joerg Sonnenberger writes:
> On Sat, May 07, 2016 at 11:49:21AM +0000, Maxime Villard wrote:
> > Module Name: src
> > Committed By: maxv
> > Date: Sat May 7 11:49:21 UTC 2016
> >
> > Modified Files:
> > src/sys/arch/amd64/amd64: locore.S
> >
> > Log Message:
> > clarify
>
> WTH. Can you please not mix arbitrary stylistic changes with refactoring
> and whatever else you have hidden in this?!
agreed. there is at least one functional change here: PROC0_STK_OFF
has changed definition. could you please explain this part?
additionally, please revert killkpt macro -- it makes it harder to
understand the assembly as it moves the 1: target into a macro so
that people will mis-reaad branch/jumps thinking they'll go to the
following 1:.
thanks.
.mrg.
Home |
Main Index |
Thread Index |
Old Index