Re: CVS commit: src/sbin/ifconfig

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wed, Sep 14, 2016 at 11:46:43AM +0000, Roy Marples wrote:
> Module Name:	src
> Committed By:	roy
> Date:		Wed Sep 14 11:46:43 UTC 2016
> 
> Modified Files:
> 	src/sbin/ifconfig: media.c
> 
> Log Message:
> Don't bail if SIOGIFMEDIA doesn't return any media lists because we
> can still report link status.

As I mentioned in the review, I think this is the wrong approach. I find
the assumption that every interface supporting the IFMEDIA interface has
at least one medium to be perfectly reasonable. Setting up and
defaulting to one AUTO medium is two lines of code. Now we have to look
for bugs in every consumer of this interface...

Joerg