Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/tests/kernel



On Thu, 10 Nov 2016, matthew green wrote:

also, root can't attach to pid1 if securelevel is >= 0.

To adjust securelevel this test would need to be modified to run under
rump ...  We wouldn't want the test to manipulate securelevel of the
running system.

s/wouldn't want/*can't* by design have/.

i don't know that running under rump is useful here.  i certainly
would not trust ptrace tests in a rump to cover it properly.  this
test should just be skipped if securelevel >= 0.  fact is that
very few systems run with securelevel these days, so it's a small
portion of systems that won't have it.

Yeah, rump probably doesn't make much sense here. Skipping the test (with atf_tc_skip(...) of course) is likely the best solution.


+------------------+--------------------------+------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+------------------+--------------------------+------------------------+


Home | Main Index | Thread Index | Old Index