Re: CVS commit: src/sys

[Ryota Ozaki <ozaki-r%netbsd.org@localhost>]

Sorry I didn't notice this reply...

On Fri, Mar 31, 2017 at 10:23 PM, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> On Fri, Mar 31, 2017 at 06:49:44AM +0000, Ryota Ozaki wrote:
>> Module Name:  src
>> Committed By: ozaki-r
>> Date:         Fri Mar 31 06:49:44 UTC 2017
>>
>> Modified Files:
>>       src/sys/netinet: ip_icmp.c ip_input.c ip_var.h tcp_input.c
>>       src/sys/sys: mbuf.h
>>
>> Log Message:
>> Don't use a single global variable to store source route information for multiple incoming packets
>>
>> It's not MP-safe. So use a m_tag to store the information instead.
>>
>> Pointed out by knakahara@
>> The fix is from OpenBSD (originally fixed in FreeBSD)
>
> Is this on any critical / typical used code path? Because it adds a
> memory allocation / free...

It's for IPv4 Source Routing and the call path isn't typical.

BTW we may need to have a sysctl switch for the feature and disable it
by default.

  ozaki-r