Le 14/06/2017 à 15:34, Joerg Sonnenberger a écrit :
On Wed, Jun 14, 2017 at 12:27:24PM +0000, Maxime Villard wrote:Module Name: src Committed By: maxv Date: Wed Jun 14 12:27:24 UTC 2017 Modified Files: src/sys/arch/amd64/include: param.h src/sys/arch/i386/include: param.h src/sys/arch/x86/x86: x86_machdep.c Log Message: Define MAXPHYSMEM globally.Given that we have an option called PHYSMEM_MAX_SIZE, I find the name a bit unfortunate.
Indeed, but they don't mean the same thing: MAXPHYSMEM is the limit of the implementation, and PHYSMEM_MAX_SIZE is user-set. I took MAXPHYSMEM because there was already MAXIOMEM nearby. Is this feature useful at all? Otherwise it seems rather clear that PHYSMEM_MAX_SIZE/PHYSMEM_MAX_ADDR are user options, so I don't think we need to rename them.