Re: CVS commit: src/sys/netinet

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 29/07/2017 à 01:59, Robert Elz a écrit :
>      Date:        Fri, 28 Jul 2017 19:16:41 +0000
>      From:        "Maxime Villard" <maxv%netbsd.org@localhost>
>      Message-ID:  <20170728191641.CF10CFACD%cvs.NetBSD.org@localhost>
>
>    | Remove TCP_COMPAT_42. This feature is a workaround for a bug in the TCP
>    | stack of BSD4.2. Having such features just does not make any sense,
>
> These days, probably not, it isn't likely that there's still anyone
> running unfixed 35 year old code any more.
>
>    | and looking at the code, I'm not sure it actually works.
>
> You didn't say which part you have doubts about.  If there was some
> flaw in the sysctl setup, which no-one noticed because no-one uses it
> any more, then I'd believe that's possible.
>
> However, if you think the code to send the 4.2 compatible keepalive
> packet was incorrect, you're mistaken, that part would have worked
> just fine.

The file I was referring to was tcp_subr.c, which I didn't commit in the
first place. In this file, I had a doubt about the +1 on tlen, and the
computations that follow. Plus the XXX for the tcp sequence, and the
"not recommended" in the config files.

This was an expeditious move, and it is clear that I didn't bother much.