Re: CVS commit: src/sys

[christos%astron.com@localhost (Christos Zoulas)]

In article <20171027113720.GB5040%britannica.bec.de@localhost>,
Joerg Sonnenberger  <joerg%bec.de@localhost> wrote:
>On Fri, Oct 27, 2017 at 09:59:17AM +0000, Utkarsh Anand wrote:
>> Module Name:	src
>> Committed By:	utkarsh009
>> Date:		Fri Oct 27 09:59:17 UTC 2017
>> 
>> Modified Files:
>> 	src/sys/arch/x86/x86: intr.c
>> 	src/sys/ddb: db_interface.h db_panic.c
>> 	src/sys/kern: init_main.c subr_autoconf.c subr_disk.c subr_prf.c
>> 	    vfs_subr.c vfs_wapbl.c
>> 	src/sys/sys: systm.h
>> 	src/sys/ufs/ufs: ufs_lookup.c
>> 
>> Log Message:
>> [syzkaller] Attempted fix for https://github.com/google/syzkaller/issues/399
>> 
>> syzkaller was failing to extract constants because of the above
>mentioned issue so I had to redeclare printf in sys/sys/systm.h
>> For more information on syzkaller, visit: https://github.com/google/syzkaller
>
>Please revert this commit immediately.
>
>(1) The commit message is useless. It doesn't provide any understandable
>justification for this change.
>
>(2) The commit itself changes a central part of the kernel without any
>review or consensus. If you want to get it recommitted, please bring it
>up FIRST on tech-kern.
>
>(3) Having to add > 10 casts in random places in a way that is at best
>implementation-defined behavior should be a huge warning sign that this
>change is a bad idea.

Yes, this needs to be undone and we need to think about this carefully
first. There are other ways to make syzcaller happy.

christos