Re: audio usemixer breaks vs(4) Re: CVS commit: src/sys/dev

[Tetsuya Isaki <isaki%NetBSD.org@localhost>]

At Tue, 07 Nov 2017 12:45:47 +0900,
Tetsuya Isaki wrote:
> 
> nat@, (cc: christos@)
> 
> With this change, vs(4) no longer works even if usemixer=0.
                                                  ^^^^^^^^^^
Oops, it should be 'usemixer=1'.

If usemixer=1, it plays noise.
If usemixer=0, failed to open sound device.

Anyway, please revert it.
---
Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>

> Please revert it, and don't break without public discussion.
> 
> This is the 3rd time you broke vs(4).
> You broke and I repaired.
> You broke and I repaired.
> I spent a lot of time this half year.
> 
> If you can not consider about supported devices (at least
> devices which has active users), please don't touch audio.
> 
> Thanks,
> ---
> Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>
> 
> At Tue, 7 Nov 2017 01:13:19 +0000,
> > Module Name:	src
> > Committed By:	nat
> > Date:		Tue Nov  7 01:13:19 UTC 2017
> > 
> > Modified Files:
> > 	src/sys/dev: audio.c audiovar.h
> > 
> > Log Message:
> > A sysctl is now available to disable the in kernel mixer.
> > 	sysctl -w hw.hdafg0.usemixer=0
> > 
> > There currently is a problem draining the last block with the mixer
> > disabled.  I will fix this in a follow up commit.
> > 
> > AFAIK there will be a problem wiht vs(4) on x68k with the mixer disabled
> > as the filters for mulaw, alaw and unsigned linear have been removed post
> > audio mixing changes.
> > 
> > Documentation for this sysctl variable will be made to audio.4 in a follow
> > up commit.
> > 
> > Ok christos@.
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.429 -r1.430 src/sys/dev/audio.c
> > cvs rdiff -u -r1.66 -r1.67 src/sys/dev/audiovar.h
>