Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys (and netbsd-8 stalled pullup request #390)



On 28/11/2017 16:36, Roy Marples wrote:
On 27/11/2017 20:27, Robert Elz wrote:
The new test should be moved down to rule 3, probably just before the
deprecated addr test, that is, a deprecated addr which is still valid
should be preferred over a detached (or tentative) addr  - detached I
will come back to in the next section, but for tentative this means that
if an old addr has become deprecated, and we're in the process of generating
a new one, but DaD has not completed yet, we keep using the old addr
until the new one is no longer tentative, and then switch (the way your
code is now would also do that - but because the check is much too violent.) This is why you might consider this just to be a coding change (with functional
side effects.)

I don't see a problem with moving the detached/tentative test there

src/sys/netinet6/in6_src.c r1.84 addresses this.

Roy



Home | Main Index | Thread Index | Old Index