Re: CVS commit: src/sys/net80211

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 20/01/2018 à 20:40, Mindaugas Rasiukevicius a écrit :
> Hi,
>
> David Young <dyoung%pobox.com@localhost> wrote:
> > On Tue, Jan 16, 2018 at 08:39:29AM +0000, Maxime Villard wrote:
> > > Module Name:	src
> > > Committed By:	maxv
> > > Date:		Tue Jan 16 08:39:29 UTC 2018
> > >
> > > Modified Files:
> > > 	src/sys/net80211: ieee80211_input.c
> >
> > ...
> >
> > IMO, changes like this are important and overdue, however, do keep in
> > mind the provenance of this code: NetBSD -> FreeBSD.
> >
> > Maybe you have written off ever re-synching with FreeBSD?  If so, do
> > you have a plan for integrating useful features like virtual stations
> > independently of their code?
>
> I can just echo this part.  It is completely unrealistic that NetBSD can
> maintain its own 802.11 stack these days. 

Well, I agree, but:

> A better approach would be to sync the code with FreeBSD and treat is as
> an upstream, trying to merge the fixes back there.  Not sure if diverging
> will help syncing the code.

My point, in the changes I made, was to fix several bugs, and along the way,
put the code in a state where it is at least readable a little.

That's not incompatible with syncing the code with FreeBSD afterwards. We
don't have more features as a result of my changes, but at least the ones we
have are less buggy.

Maxime