Re: CVS commit: src/sys/dev

[Paul Goyette <paul%whooppee.com@localhost>]

If you're going to #include an opt_*.h file, perhaps you ought to embed 
that within #ifdef _KERNEL_OPT

In the distant future, if/when acpi becomes a module, it will get built 
in an environment that does not include the opt_*.h files (all needed 
macros such as NPCI get supplied via CPPFLAGS in the module's Makefile).

:)


On Thu, 1 Mar 2018, Masanobu SAITOH wrote:

> On 2018/03/01 14:04, maya%netbsd.org@localhost wrote:
> > On Wed, Feb 28, 2018 at 05:50:06AM +0000, SAITOH Masanobu wrote:
> > > Module Name:	src
> > > Committed By:	msaitoh
> > > Date:		Wed Feb 28 05:50:06 UTC 2018
> > >
> > > Modified Files:
> > > 	src/sys/dev/acpi: acpi_mcfg.c
> > > 	src/sys/dev/pci: pci_quirks.c pcivar.h
> > >
> > > Log Message:
> > > - Add new PCI quirk PCI_QUIRK_HASEXTCNF and PCI_QUIRK_NOEXTCNF. Some 
> > > devices'
> > >    extended configuration area may be broken or violate spec. If an 
> > > extended
> > >    configuration space is strange but it really exist, use 
> > > PCI_QUIRK_HASEXTCNF.
> > >    If an extended configuration space is plausible to exist but it really
> > >    doesn't exist, use PCI_QUIRK_NOEXTCNF.
> > > - Add PCI_PRODUCT_INTEL_XEOND_MEM_0_TTR_1(0x6fa8) and
> > >    PCI_PRODUCT_INTEL_COREI76K_IMC_0(0x6f68) with PCI_QUIRK_HASEXTCNF. The
> > >    document clearly states they violate spec and it support the extended
> > >    configuration space.
> >
> > this is causing ia64 builds to fail. they have acpi, but not pci
> > defined. then, pci_quirks.c is not built, and we get an undefined
> > reference:
> >
> > http://releng.netbsd.org/builds/HEAD/201802282130Z/ia64.build.failed
> >
> > acpi_mcfg.c sounds like a very pci-only thing, from commit history.
> > the following patch makes it explicitly a pci only thing, although I
> > haven't tried to boot it. Is this the right thing?
>
> IMHO, it would be OK.
>
> > With this change, I can build amd64 and ia64 kernels.
>
>
> --
> -----------------------------------------------
>                SAITOH Masanobu (msaitoh%execsw.org@localhost
>                                 msaitoh%netbsd.org@localhost)
>
> !DSPAM:5a97918b157948785462255!

+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+