On 18.04.2018 01:29, Kamil Rytarowski wrote: > On 17.04.2018 23:50, Michael van Elst wrote: >> On Tue, Apr 17, 2018 at 05:45:13PM +0200, Kamil Rytarowski wrote: >>> On 04.03.2018 08:13, Michael van Elst wrote: >>>> Module Name: src >>>> Committed By: mlelstv >>>> Date: Sun Mar 4 07:13:11 UTC 2018 >>>> >>>> Modified Files: >>>> src/sys/sys: device.h >>>> >>>> Log Message: >>>> Expose device structures to _KMEMUSER >>>> >>>> >>> >>> This broke building device.h with _KMEMUSER. >>> >>>> @@ -81,7 +81,7 @@ >>>> #include <sys/evcnt.h> >>>> #include <sys/queue.h> >>>> >>>> -#ifdef _KERNEL >>>> +#if defined(_KERNEL) || defined(_KMEMUSER) >>>> #include <sys/mutex.h> >>>> #include <sys/condvar.h> >>>> #include <sys/pmf.h> >>> >>> The sys/pmf.h header is not accessible from userland. >> >> True. >> >> What program includes device.h as _KMEMUSER but crash(8) ? There >> shouldn't be any. >> >> crash helps itself by including system headers, but that's probably >> not a good recipe for everyone. >> >> >> >> Greetings, >> > > I'm including this header indirectly in compiler-rt (with local > patches). I have a long list of includes and _KMEMUSER on top. > > It's included at least through <dev/biovar.h> -> <sys/device.h> -> > <sys/pmf.h>. > > https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc > + local patch > https://github.com/NetBSD/pkgsrc-wip/blob/master/compiler-rt-netbsd/patches/patch-lib_sanitizer__common_sanitizer__platform__limits__netbsd.cc > > This code used to build and work before that change. > Looking at other users, everyone except <dev/biovar.h> include <sys/device.h> in the _KERNEL namespace.
Attachment:
signature.asc
Description: OpenPGP digital signature