Re: CVS commit: src/sys/arch

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 20/06/2018 à 21:26, Jaromír Doleček a écrit :
> 2018-06-20 18:03 GMT+02:00 Maxime Villard <max%m00nbsd.net@localhost>:
> > I haven't tested but looking at the code it seems to me that this part of
> > your
> > change breaks DAZ on native, and I don't see how it can help xsave on xen by
> > the way
>
> Thanks, I'll change the conditional to avoid any potential change of
> behaviour for native.

Your change was still wrong, and I've reverted it.

It made no sense: no-xsave can't disable fxsave, because even if you don't
call it in fpuinit_mxcsr_mask, it still gets called in the rest of the fpu
code.

I see on current-users@ that xen machines are crashing now; as I said already,
there was a stack alignment problem there several months ago. Looking at the
crash report, it's still the same problem it seems.

No point adding nonsensical conditionals there, you just broke both native
and xen.

Also, your changes in XSAVE are still wrong to me, so please fix that
correctly - as I said in my first email, the detection logic should be done
in identcpu.c (unless there is a good reason for not doing so, which there
doesn't seem to be), and you shouldn't enable FXSAVE if XSAVE is not
supported because it may be that *neither* is supported.

Maxime