Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



In article <fdf88c3c-5a71-819f-8aae-29c389cc510a%gmx.com@localhost>,
Kamil Rytarowski  <n54%gmx.com@localhost> wrote:
>-=-=-=-=-=-
>-=-=-=-=-=-
>
>On 09.07.2018 16:07, Christos Zoulas wrote:
>> Module Name:	src
>> Committed By:	christos
>> Date:		Mon Jul  9 14:07:37 UTC 2018
>> 
>> Modified Files:
>> 	src/sys/arch/evbarm/stand/boot2440: dev_sdmmc.c
>> 	src/sys/arch/mips/sibyte/dev: sbjcnvar.h
>> 	src/sys/dev/sbus: magmareg.h spifreg.h
>> 
>> Log Message:
>> Remove duplicate copies of the SET/CLR/ISSET macros.
>> 
>
>There are still duplicates of at least __BIT(9) and __BITS(9),
>__SHIFTOUT(9), __SHIFTIN(9) etc.
>
>I propose to deduplicate them too.

These are in arm/include/asm.h. I am all for removing them, but someone will
need to test the build.

There is also a bunch of __BIT16 __BIT32 etc which are casts to __BIT...

christos



Home | Main Index | Thread Index | Old Index