Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/share/mk



On Jul 10,  9:58pm, martin%duskware.de@localhost (Martin Husemann) wrote:
-- Subject: Re: CVS commit: src/share/mk

| On Tue, Jul 10, 2018 at 08:31:16PM +0200, Joerg Sonnenberger wrote:
| > This is wrong. Please revert. The seed should be specific per source as
| > it is used to distinguish e.g. anonymous namespace mangling.

It is still specific per source since the ${.TARGET} contains the source
name (i.e. foo.c -> foo.o):

__BUILDSEED=    ${BUILDSEED}/${__INITSEED}/${.TARGET} 

It does not contain *all* the sources like before, but one source should
be enough, or not?

| Can we just use the (normalized/sub-) path of the target object file?
| I don't understand why any source comes in here and obfuscates things.

Anyway, the fix to remove the files that contain relative paths should
make things deterministic again; I just wanted to make sure that they
were, and keeping this simple (using the timestamp) sounded like a good
idea (unless you need a better guarantee of uniqueness than the single
source name).

christos


Home | Main Index | Thread Index | Old Index